Add authentication and NuGet feed configuration to the YAML file for fetching and restoring packages. - #1100
Open
v-ochoudhary wants to merge 13 commits into
Open
v-ochoudhary wants to merge 13 commits into
v-ochoudhary wants to merge 13 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
Clearing existing sources may prevent required packages from restoring unless the configured feed provides the necessary upstreams.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR standardizes authenticated NuGet restores across Azure Pipelines.
Changes:
- Adds centralized
src/nuget.config. - Authenticates NuGet feeds before restores.
- Configures restore tasks to use the shared configuration.
- Updates network isolation settings.
File summaries
| File | Description |
|---|---|
src/nuget.config |
Defines the shared package source. |
build/signedbuild.yml |
Updates authenticated signed-build restores. |
build/prbuild.yml |
Updates authenticated PR-build restores. |
build/check-dependencies.yml |
Updates authenticated dependency checks. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
v-ochoudhary
changed the title
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
Critical credential-exposure and template-path issues, plus a coverage-upload path bug, remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Lite
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This pull request introduces a new authentication mechanism for accessing a private Azure DevOps NuGet feed in CI builds, and updates build pipelines to ensure secure and consistent package restoration. It also updates the
WixToolset.Sdkversion for the installer project and adds a dedicatednuget.configfor package source configuration.Build pipeline improvements:
build/authenticate-private-feed.yml) that authenticates to the private Azure DevOps NuGet feed using Workload Identity Federation and updates the agent’snuget.configwith the required credentials.build/prbuild.yml,build/signedbuild.yml, andbuild/check-dependencies.yml) to use the new authentication template before any NuGet or dotnet restore steps, and configured all restore tasks to use the newsrc/nuget.configfile and the authenticated feed. [1] [2] [3] [4] [5] [6] [7] [8]networkIsolationPolicy: Permissive,CFSCleanin pipeline jobs to allow access to the private feed in a secure manner. [1] [2]Configuration updates:
src/nuget.configfile specifying the privatea11y-insights-publicfeed as the sole package source for builds.Build tooling update:
WixToolset.Sdkversion from4.0.1to4.0.2insrc/CLI_Installer/CLI_Installer.wixprojfor the installer build.Motivation
Fix PR checks failed due to nuget package is not restore.
Pull request checklist