fix(layout): Keep popups inside the editor on small screens and deep stacks - #47
Merged
Conversation
…stacks clamp() returned min when min exceeded max, so a min_size larger than the editor bypassed the screen bound entirely: on a 30-column screen the third stacked popup was still computed 60 columns wide. Offsets were also applied without an upper bound, pushing deep stacks past the right and bottom edges, and the popup border was never accounted for although every popup is opened with border = "rounded". - Make clamp() prefer max when the range is inverted, so the editor size always wins over a too-large min_size. - Reserve the two border cells when sizing and clamp row/col after the cascade offset, so width, height and position keep the whole popup on screen at any stack depth. - Size the zoomed popup to the editor minus its border instead of the full editor, which used to place the right and bottom border off screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_sizelarger than the editor no longer bypasses the screen bound: on a 30-column screen the third stacked popup used to be computed 60 columns wide.Changes
clamp()prefer max on an inverted range, so the editor size always wins over a too-largemin_size.min_sizecase, and the zoomed popup.