Conversation
2 tasks
…maximum cell method. MOBT-1020.
bayliffe
force-pushed
the
threshold_vicinity_fix
branch
from
August 26, 2026 07:43
16f2585 to
f42ab09
Compare
Contributor
|
See improver PR for comment |
Kat-90
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: https://github.com/metoppv/mo-blue-team/issues/1020, metoppv/improver#2439
Threshold outputs with a vicinity applied updated to include an area maximum cell method.
Changes
For all but one of the diagnostic the only change is the addition of the new cell method, as shown using
nccmp -dmNsgf, the output of which is below.data/threshold/vicinity/kgo.nc
DIFFER : VARIABLE "probability_of_rainfall_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_rainfall_rate_in_vicinity_above_threshold : 4 <> 5
data/threshold/vicinity/kgo_collapsed.nc
DIFFER : VARIABLE "probability_of_rainfall_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo_collapsed.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_rainfall_rate_in_vicinity_above_threshold : 4 <> 5
data/threshold/vicinity/kgo_landmask.nc
DIFFER : VARIABLE "probability_of_rainfall_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo_landmask.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_rainfall_rate_in_vicinity_above_threshold : 4 <> 5
data/threshold/vicinity/kgo_landmask_collapsed.nc
DIFFER : VARIABLE "probability_of_rainfall_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo_landmask_collapsed.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_rainfall_rate_in_vicinity_above_threshold : 4 <> 5
data/threshold/vicinity/kgo_masked.nc
DIFFER : VARIABLE "probability_of_lwe_precipitation_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo_masked.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_lwe_precipitation_rate_in_vicinity_above_threshold : 4 <> 5
data/threshold/vicinity/kgo_multiple_vicinities.nc
DIFFER : VARIABLE "probability_of_rainfall_rate_in_vicinity_above_threshold" IS MISSING ATTRIBUTE WITH NAME "cell_methods" IN FILE "../reference/data/threshold/vicinity/kgo_multiple_vicinities.nc"
DIFFER : NUMBER OF ATTRIBUTES : VARIABLE : probability_of_rainfall_rate_in_vicinity_above_threshold : 4 <> 5
The only exception is the nowcast related test for which there were precision level differences in some values.
data/threshold/nowcast/kgo_masked.nc
DIFFER : LENGTHS : ATTRIBUTE : cell_methods : VARIABLE : probability_of_lwe_thickness_of_precipitation_amount_in_vicinity_above_threshold : 61 <> 71 : VALUES : "time: sum (comment: of lwe_thickness_of_precipitation_amount)" : "area: maximum time: sum (comment: of lwe_thickness_of_precipitation_amount)"
These same difference are found when comparing a new KGO generated using the master branch prior to this change, suggesting this is a result of some package change leading to precision level changes. These do not show in the standard running of the testing due to the allowed tolerances.
I will update this KGO in full as that better aligns the values with master's output as well as including the new cell method.