Conversation
mendhak
commented
Sep 7, 2026
| "node": ">=16.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@httptoolkit/httpolyglot": "^3.1.0", |
Owner
Author
There was a problem hiding this comment.
This does some fancy header sniffing to figure out HTTP1 vs HTTP2
mendhak
commented
Sep 7, 2026
| key: require('fs').readFileSync(process.env.HTTPS_KEY_FILE || 'testpk.pem'), | ||
| cert: require('fs').readFileSync(process.env.HTTPS_CERT_FILE || 'fullchain.pem'), | ||
| maxHeaderSize: maxHeaderSize | ||
| ALPNProtocols: [ 'h2', 'http/1.1'], |
Owner
Author
There was a problem hiding this comment.
Default HTTP2, fallback HTTP1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic HTTP2 working, but may need to add some HTTP2 specific tests
I think HTTP 2 should be the default. There are some HTTP 1 specific things though that need addressing.
Issue #36