Conversation
Testing a meeting with several participants means editing fullName by hand before every join, and the generated "User 1234567" tells nothing about which participant is which once they are in the meeting. Add two independent toggles to the options bar. "Assign random names" fills fullName with a realistic name from Faker instead of the numbered one. "New name on each join" picks a new name every time a join link is opened, so repeated joins enter as different people without touching the menu. They are kept apart so the rotation also works with the numbered names, for anyone who does not want Faker names. Defer the rotation with a zero timeout: regenerating the links replaces the anchor that was clicked, and doing that during the click cancels the navigation the browser is about to perform. Vendor Faker as a locale-specific ES module bundle instead of loading it from a CDN, so the page keeps working offline and the version is pinned in the repository. The page has no bundler, so a prebuilt bundle is the only option short of adding one. Leave the userID input alone in every combination of the toggles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Testing a meeting with several participants means editing fullName by hand before every join, and the generated "User 1234567" tells nothing about which participant is which once they are in the meeting. Realistic names also make it easier to test features that depend on them, like user name search.
Add two independent toggles to the options bar. "Assign random names" fills fullName with a realistic name from Faker instead of the numbered one. "New name on each join" picks a new name every time a join link is opened, so repeated joins enter as different people without touching the menu. They are kept apart so the rotation also works with the numbered names, for anyone who does not want Faker names.
Defer the rotation with a zero timeout: regenerating the links replaces the anchor that was clicked, and doing that during the click cancels the navigation the browser is about to perform.
Vendor Faker as a locale-specific ES module bundle instead of loading it from a CDN, so the page keeps working offline and the version is pinned in the repository. The page has no bundler, so a prebuilt bundle is the only option short of adding one.