Skip to content

PowderN fix potential edge cases - #2579

Draft
willend wants to merge 11 commits into
mainfrom
PowderN-fix-potential-edge-cases
Draft

PowderN fix potential edge cases#2579
willend wants to merge 11 commits into
mainfrom
PowderN-fix-potential-edge-cases

Conversation

@willend

@willend willend commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:

Patches for 2 rare, potential pitfalls:

  1. Over/underrun of reflection list in calc_xsect()
  2. Add guard for rand01()==1.0 edge case

Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:

Once in a while one or more of the Test_Powders tests are off. Used Claude-prompts to pinpoint potential issue areas in PowderN.


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution contains something else

    • Explanation is added in free form text above or below the checklist

@willend
willend marked this pull request as draft September 10, 2026 07:01
@willend

willend commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Put to 'draft' mode - it seems that the issues we attempted to fix here were rather corrected via #2634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant