Skip to content

fix(firmware): reject malformed setWifi and keep the WiFi password out of the log #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaka1022 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(firmware): reject malformed setWifi and keep the WiFi password out of the log #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2e9548
fix(firmware): reject setWifi messages without an ssid or password
isaka1022 Aug 30, 2026
febcfdb
fix(firmware): stop logging the WiFi password
isaka1022 Aug 30, 2026
036eade
chore(firmware): ignore sdkconfig.defaults.local
isaka1022 Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firmware/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@ obj/

sdkconfig
sdkconfig.old
sdkconfig.defaults.local

xiaozhi-esp32/
8 changes: 7 additions & 1 deletion firmware/main/hal/hal_ble.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,13 @@ class WifiConfigServer {
const char* ssid = data["ssid"];
const char* password = data["password"];

mclog::tagInfo(_tag, "get wifi config: {} / {}", ssid, password);
if (ssid == nullptr || password == nullptr) {
mclog::tagWarn(_tag, "setWifi is missing ssid or password");
notify_state(2, "wifiConnectFailed");
return;
}

mclog::tagInfo(_tag, "get wifi config for ssid: {}", ssid);

// Notify state: connecting
notify_state(0, "wifiConnecting");
Expand Down