devfreq: add DEVFREQ_GOVERNOR to set the governor of devfreq devices - #903
devfreq: add DEVFREQ_GOVERNOR to set the governor of devfreq devices#903wxphaha wants to merge 1 commit into
Conversation
Add new parameters DEVFREQ_GOVERNOR_ON_PRF/BAL/SAV to set the governor of devfreq devices, e.g. GPU, DDR or NoC frequency controllers such as the Phytium NoC (phytium_nocfreq driver). The governor is applied to all /sys/class/devfreq/devfreq*/governor devices, mirroring the existing CPU scaling governor implementation. When unconfigured (default), no changes are made. A governor rejected by the kernel is reported as a configuration error. Tested on hardware with two devfreq devices (Phytium NoC): - tlp performance -> governor=performance - tlp balanced -> governor=simple_ondemand - tlp power-saver -> governor=powersave Log: add DEVFREQ_GOVERNOR parameters for devfreq devices
|
Hi there. At first glance, it seems to me that the range of target hardware for this is a small niche. In the mainline kernel, I can only find the driver for NVIDIA Tegra: https://github.com/search?q=repo%3Atorvalds%2Flinux+devfreq_governor&type=code The Phytium NoC is not laptop hardware, nor is the phytium_nocfreq driver included in the mainline kernel (which is usually a prerequisite for a feature to be included in TLP). I can't find any information about this online at all. So far, I don’t see your PR falling within the scope of TLP. Do you have more information? |
|
Thanks for the thorough review and for taking the time to look into To clarify the background: Phytium is a Chinese processor vendor whose You are right, though, that phytium_nocfreq is not yet part of the |
|
Thanks for the info. I had already suspected that there isn't much to be found on Google about recent developments in China. I'm still unsure what role the Pythium NoC serves here. Is it just a network controller/coprocessor integrated on chip with the main CPU and/or GPU? devfreq seems to be a universal control option for multiple hardware categories. I'm struggling to fit it into the categories established in TLP. This is significant because it helps users to find it, for example, in tlp.conf or the output of tlp-stat. Speaking of tlp-stat: we'll need something there, too. If only because the user wants to know, “Do I have this in my PC?” |
Add new parameters DEVFREQ_GOVERNOR_ON_PRF/BAL/SAV to set the governor of devfreq devices, e.g. GPU, DDR or NoC frequency controllers such as the Phytium NoC (phytium_nocfreq driver).
The governor is applied to all /sys/class/devfreq/devfreq*/governor devices, mirroring the existing CPU scaling governor implementation. When unconfigured (default), no changes are made. A governor rejected by the kernel is reported as a configuration error.
Tested on hardware with two devfreq devices (Phytium NoC):
Log: add DEVFREQ_GOVERNOR parameters for devfreq devices