Always specialize std::numeric_limits for DualNumber - #80
Open
GiudGiud wants to merge 1 commit into
Open
Conversation
refs roystogner/metaphyscl#91 The DualNumber numeric_limits specialization was only placed in namespace std under METAPHYSICL_ENABLE_STD_VIOLATION, which defaults to off. Without it, std::numeric_limits<ADReal> fell back to the primary template, whose epsilon() value-initializes to a zero DualNumber. Specializing std::numeric_limits for a program-defined type is explicitly permitted by the standard, so provide it unconditionally (guarded against duplication when the std-violation path already defines it). Co-Authored-By: Claude <noreply@anthropic.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs roystogner/metaphyscl#91
The DualNumber numeric_limits specialization was only placed in namespace std under METAPHYSICL_ENABLE_STD_VIOLATION, which defaults to off. Without it, std::numeric_limits fell back to the primary template, whose epsilon() value-initializes to a zero DualNumber. Specializing std::numeric_limits for a program-defined type is explicitly permitted by the standard, so provide it unconditionally (guarded against duplication when the std-violation path already defines it).