Skip to content

ci: lint workflow files with actionlint - #892

Merged
chenson2018 merged 2 commits into
leanprover:mainfrom
jessealama:ci/actionlint
Sep 16, 2026
Merged

chenson2018 merged 2 commits into
leanprover:mainfrom
jessealama:ci/actionlint

Conversation

@jessealama

@jessealama jessealama commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Adds a workflow that runs actionlint over the .github/workflows directory whenever those files change. actionlint checks expression types (used in the little GitHub Action DSL), undefined step/output references and needs/if conditions, and runs shellcheck over every run: shell block and pyflakes over shell: python chunks.

To make sure that adding this workflow does not immediately break the build, I did a manual one-off run and found one thing, which is fixed here: an echo | sed pipeline that is now a parameter expansion.

# Conflicts:
#	.github/workflows/lean_action_ci.yml

@chenson2018 chenson2018 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chenson2018
chenson2018 added this pull request to the merge queue Sep 16, 2026
Merged via the queue into leanprover:main with commit b55fc86 Sep 16, 2026
4 checks passed
@jessealama
jessealama deleted the ci/actionlint branch September 16, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants