Conversation
packages/ai/README.md and packages/client/README.md named ld-stg.launchdarkly.com as the staging value for LD_UI_BASE_URI, and test_evaluations.py used it as a fixture. This repository is public, so that published an internal hostname for no benefit: a reader setting LD_UI_BASE_URI needs to know the option exists and why, not the name of LaunchDarkly's own non-production host, which they cannot reach anyway. Both README entries now say what the option is for -- set it for a non-production project, or its runs still link to the production app -- without naming a host. The tests move to ui.staging.example.com, which is the convention the rest of that file already follows (api.staging.example.com, relay.example.com, other.example.com, ui.example.com), so ld-stg was the only outlier. Distinct from ui.example.com on purpose: that test asserts the explicit option wins over the environment variable, which needs two different values to mean anything. Found while reviewing #89, but present on main independently of it and in three files that PR does not touch, so it is fixed here rather than inside a feature branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
donei003
requested review from
XieX,
aknight-ld,
andrewklatzke and
jeffdupont
September 18, 2026 00:01
aknight-ld
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ld-stg.launchdarkly.comappeared in four places in this public repository. Spotted in the diff of #89, but present onmainindependently of it and in three files that PR does not touch — so it is fixed here, on its own, rather than gated behind a feature branch.packages/ai/README.mdLD_UI_BASE_URI(for example,https://ld-stg.launchdarkly.comin staging)"packages/client/README.mdhttps://ld-stg.launchdarkly.com"packages/client/tests/test_evaluations.py×2Change
The READMEs now say what the option is for, without naming a host. That is the part a reader actually needs — and the part that was missing:
Naming LaunchDarkly's own non-production host helped nobody: an external reader cannot reach it, and an internal one does not learn it from an SDK README.
The tests move to
ui.staging.example.com, which is the convention the rest of that file already follows —api.staging.example.com,relay.example.com,other.example.com,ui.example.com.ld-stgwas the only outlier. It stays distinct fromui.example.comon purpose: that test asserts the explicit option beats the environment variable, which needs two different values to mean anything.Scope check
Grepped
ld-stg,stg.launchdarkly, andlaunchdarkly-stgacross the whole tree — these four were all of them, and the tree is now clean. The siblingai-sdks-monorepo(internal) andai-sdk-evaluations-example(private) never mentioned it.Validation
uv run pytest -q— 1250 passed, 11 skipped.ruff checkclean.Not a draft: it is four lines, self-contained, and the sooner it is off a public
mainthe better.🤖 Generated with Claude Code
Note
Overview
Removes
ld-stg.launchdarkly.comfrom the public tree and replaces it with guidance that does not name LaunchDarkly’s internal staging app.README updates in
packages/ai/README.mdandpackages/client/README.mdnow describeLD_UI_BASE_URI/ui_base_urias controlling evaluation-run links (defaulthttps://app.launchdarkly.com) and say to set it for non-production projects so runs do not still point at the production app—without listing a staging URL.Tests in
test_ui_base_uri_precedence_and_api_base_isolationusehttps://ui.staging.example.com, matching the file’s existing*.example.comstaging fixtures and staying distinct fromui.example.comfor the explicit-vs-env precedence assertion.No runtime or API behavior changes—documentation and test data only.
Reviewed by Cursor Bugbot for commit 00b8dba. Bugbot is set up for automated code reviews on this repo. Configure here.