docs: Describe long evaluation and domain scoping in the feature matrix - #67
Open
kinyoklion wants to merge 2 commits into
Open
kinyoklion wants to merge 2 commits into
kinyoklion wants to merge 2 commits into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
@cursor review |
kinyoklion
commented
Sep 23, 2026
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
kinyoklion
marked this pull request as ready for review
September 23, 2026 16:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the feature matrix up to date with capabilities the OpenFeature Java SDK added since the matrix was written (
getLongEvaluationand domain-bound provider initialization in 1.22.0).Requirements
Related issues
None.
Implementation details
Verified against the OpenFeature Java SDK 1.22.1
FeatureProviderinterface:getLongEvaluationhas a default implementation delegating togetDoubleEvaluationwith safe-range checks, andinitialize(EvaluationContext, String domain)plusisDomainScoped()are defaults the provider correctly leaves alone — the LaunchDarkly client holds no per-domain state.No behavior change was needed: overriding
getLongEvaluationwould not improve precision, because LaunchDarkly numeric flag values are JSON numbers surfaced as doubles.Documentation only; no code or tests changed.
Link to Devin session: https://app.devin.ai/sessions/a47abf28ecd44130917b9b5131287221
Open in Devin Desktop: https://app.devin.ai/desktop/session/a47abf28ecd44130917b9b5131287221?variant=devin
Requested by: @kinyoklion
Note
Overview
Updates the README feature matrix to document OpenFeature Java SDK 1.22.x behavior—no runtime or test changes.
The Providers row now explains that long flag evaluation relies on the SDK default (
getDoubleEvaluationwith range/fraction checks), not a custom provider override. The Domains row clarifies that the provider is notisDomainScopedand a single instance can be registered for multiple domains because it holds no per-domain state.Reviewed by Cursor Bugbot for commit b9c9413. Bugbot is set up for automated code reviews on this repo. Configure here.