Retry rate-limited flag requests - #253
Draft
austinbutler wants to merge 1 commit into
Draft
austinbutler wants to merge 1 commit into
austinbutler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ I meant to open this against our own fork, but GitHub's UI defaulted to here and I hit open PR before I realized. My plan is to run the code from this change internally in our CI, then if I'm confident it solves the problem adequately I'll mark this PR as ready. In the meantime I figured no much reason to close this out even if it was opened accidentally, you all just get an earlier preview of my intention I suppose.
Following my own PR #251, I noticed a higher rate of 429s from LaunchDarkly's API. Makes sense, pagination means more requests.
So this PR adds retries. It's based on your own documentation for rate limiting.
Please feel free to do what you want with this PR, for example if lots of changes are needed and you want to do it yourself, take whatever you want from this PR. I only want to raise the issue and ensure it gets addressed somehow.