[potentially breaking] update to use pybind11 submodule - #653
Merged
Conversation
adamdempsey90
approved these changes
Aug 31, 2026
adamdempsey90
left a comment
Collaborator
There was a problem hiding this comment.
The replacement of the FetchContent stuff from before with just add_subdirectory seems like the correct thing to do but the CI will be the arbiter
Co-authored-by: Adam M. Dempsey <adempsey@lanl.gov>
Co-authored-by: Adam M. Dempsey <adempsey@lanl.gov>
Collaborator
Author
|
Tests passing on re-git. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I am setting up CI for riot, which does not use spack, and I am finding that including pybind11 via git submodules is less painful than via pybind11. I think because we do everything via spack or via git submodules this should not be breaking but we should double check by making sure all the CI passes.
This does make pybind11 more in-line with how we treat other dependencies in singularity-eos so I think it's reasonable.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: