Skip to content

[potentially breaking] update to use pybind11 submodule - #653

Merged
Yurlungur merged 6 commits into
mainfrom
jmm/pybind11
Sep 1, 2026
Merged

[potentially breaking] update to use pybind11 submodule#653
Yurlungur merged 6 commits into
mainfrom
jmm/pybind11

Conversation

@Yurlungur

@Yurlungur Yurlungur commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

I am setting up CI for riot, which does not use spack, and I am finding that including pybind11 via git submodules is less painful than via pybind11. I think because we do everything via spack or via git submodules this should not be breaking but we should double check by making sure all the CI passes.

This does make pybind11 more in-line with how we treat other dependencies in singularity-eos so I think it's reasonable.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur self-assigned this Aug 31, 2026
@Yurlungur Yurlungur added the build Something to do with the build system label Aug 31, 2026

@adamdempsey90 adamdempsey90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replacement of the FetchContent stuff from before with just add_subdirectory seems like the correct thing to do but the CI will be the arbiter

Comment thread cmake/singularity-eos/pybind11.cmake Outdated
Comment thread python/CMakeLists.txt Outdated
jonahm-LANL and others added 3 commits September 1, 2026 12:00
Co-authored-by: Adam M. Dempsey <adempsey@lanl.gov>
Co-authored-by: Adam M. Dempsey <adempsey@lanl.gov>
@Yurlungur

Copy link
Copy Markdown
Collaborator Author

Tests passing on re-git. Merging.

@Yurlungur
Yurlungur merged commit a91489d into main Sep 1, 2026
10 checks passed
@Yurlungur
Yurlungur deleted the jmm/pybind11 branch September 1, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Something to do with the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants