Skip to content

Add cache-level predicate support for informers - #4896

Open
brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:fix-cache-level-predicate-support
Open

Add cache-level predicate support for informers#4896
brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:fix-cache-level-predicate-support

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

Splits cache-level informer predicate changes out of #4892.

Summary

  • allow informer factories to accept cache predicates
  • filter objects at the cache layer
  • emit the appropriate add, update, and delete notifications as objects enter or leave the cache predicate
  • add unit and end-to-end coverage

Validation

  • ./mvnw -q -pl util,e2e -am compile test-compile -DskipTests

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 September 1, 2026 19:10
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: brendandburns / name: Brendan Burns (f0442fb)

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 1, 2026
@brendandburns
brendandburns force-pushed the fix-cache-level-predicate-support branch from 09411ec to f0442fb Compare September 1, 2026 19:21
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 1, 2026
@brendandburns
brendandburns force-pushed the fix-cache-level-predicate-support branch from f0442fb to 7c8cd35 Compare September 1, 2026 19:56

@yue9944882 yue9944882 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants