CLI: Update Go SDK to 6e62bf5b91e5d315b90b6c9c7296e09e312fb338 - #231
Open
kernel-internal[bot] wants to merge 4 commits into
Open
CLI: Update Go SDK to 6e62bf5b91e5d315b90b6c9c7296e09e312fb338#231kernel-internal[bot] wants to merge 4 commits into
kernel-internal[bot] wants to merge 4 commits into
Conversation
Bump github.com/kernel/kernel-go-sdk to v0.91.1-0.20260817203807-0a287359dcc5 (0a28735). Coverage gap found by enumerating all 140 methods in the SDK's api.md against the CLI command tree: the new Organization.Entitlements resource had no CLI surface. Everything else was already covered. New command: - `kernel org entitlements get` for client.Organization.Entitlements.Get (GET /org/entitlements). Renders Plan, Features, and Limits sections; supports --output json. Null constraint values mean unlimited in this API, and the SDK models them as non-pointer int64, so rendering keys off respjson field validity rather than the zero value. Tested against the real API: - kernel org entitlements get (table output, ENTERPRISE plan) - kernel org entitlements get --output json - kernel org entitlements get --output yaml (rejected as expected) - go build ./... and go test ./... pass, including 5 new unit tests covering populated constraints, null-as-unlimited, null plan fields, invalid --output, and API errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Updates github.com/kernel/kernel-go-sdk from
v0.91.1-0.20260817203807-0a287359dcc5 to v0.92.0.
## Coverage Analysis
Diffing the two module sources shows the SDK API surface is byte-identical
between these versions -- the only changes are release metadata
(.release-please-manifest.json, CHANGELOG.md, README.md, internal/version.go).
A full enumeration was still performed:
- All 140 SDK methods in api.md have corresponding CLI commands.
- The 4 x-cli-skip endpoints (/site-configs/lookup, /site-configs/resolve,
/site-configs/analyses/{id}, /auth/connections/{id}/exchange) are absent
from the SDK surface, so nothing to skip.
- All params struct fields are covered by CLI flags except three, each
intentional:
- AuthConnectionLoginParams.BrowserTelemetry -- deprecated in favor of
browser.telemetry, which the CLI already uses via ManagedAuthBrowserConfigParam.
- AuditLogListParams.PageToken -- opaque cursor handled internally by
ListAutoPaging; CLI exposes --limit instead.
- BrowserCurlParams.TimeoutMs / ResponseEncoding -- `browsers curl` is
implemented against browsers.HTTPClient rather than the SDK curl endpoint;
--max-time covers the timeout and raw bytes are streamed, so response
encoding is not applicable.
No coverage gaps found; no new commands or flags added.
## Tested
- go build ./... and go vet ./... clean
- go test ./... all packages pass
- Smoke tested rebuilt binary against the live API: `kernel browsers list`
Triggered by: kernel/kernel-go-sdk@a156820
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Bumps kernel-go-sdk to 6e62bf5b91e5d315b90b6c9c7296e09e312fb338.
That SDK release reshapes the canonical managed-auth input field: the
boolean `replace_existing` is gone and a `reason` enum ("missing" |
"rejected") takes its place, so `auth connections get` and the
`auth connections follow` event stream now render `reason=<why>` instead
of the `replace-existing` marker. A rejected credential is still visible,
now alongside the missing-value case it could not previously express.
A full enumeration of api.md against the CLI's service interfaces and
flags found no other coverage gaps: all 136 non-x-cli-skip SDK methods
have commands, and every params field maps to an existing flag.
Tested: auth connections list, auth connections get <id> (table + json),
browsers create -t 60, browsers get <id>, browsers delete <id> against
the live API; go build ./... and go test ./cmd/... pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK to 6e62bf5b91e5d315b90b6c9c7296e09e312fb338 and adapts the CLI to a changed managed-auth response field.
SDK Update
Coverage Analysis
This PR was generated by performing a full enumeration of SDK methods and CLI commands.
All 140 methods in
api.mdwere checked against the CLI's service interfaces and direct client calls. 4 endpoints are markedx-cli-skip: trueinopenapi.yamland are excluded (post /site-configs/lookup,post /site-configs/resolve,get /site-configs/analyses/{id},post /auth/connections/{id}/exchange). The remaining 136 all have CLI commands. Every field of every*Paramsstruct was also matched against the CLI's registered flags — no missing flags were found.New Commands
None — the SDK diff between
v0.92.0and this revision adds no new endpoints or params.Changed Behavior
The canonical managed-auth input field was reshaped in this SDK release:
ManagedAuthField.ReplaceExisting(bool) was removedManagedAuthField.Reason("missing"|"rejected") was addedkernel auth connections getand thekernel auth connections followevent stream previously rendered areplace-existingmarker on a field. They now renderreason=<why>, which still surfaces the rejected-credential case and additionally distinguishes it from a simply-missing value. Without this change the CLI does not compile against the new SDK.Testing
go build ./...andgo test ./cmd/...passauth connections list,auth connections get <id>(table and-o json),browsers create -t 60,browsers get <id>,browsers delete <id>TestAuthConnectionsGet_PrintsCanonicalInputMetadataTriggered by: kernel/kernel-go-sdk@6e62bf5
Reviewer: @kernel-internal[bot]
Note
Low Risk
Read-only org entitlements command and managed-auth display tweaks aligned with the SDK; no changes to auth flows or credential handling logic.
Overview
Bumps kernel-go-sdk and adds CLI support for newer API shapes.
kernel org entitlements getshows effective plan (including effective plan vs contractual, trialing, billing status, trial end), per-feature enablement with constraints (e.g. extension caps, replay retention, managed auth connection and health-check intervals), and org concurrency limits. Nullable caps render asunlimited; missing plan fields as-. Supports--output json. Documented in the README.Managed auth connections (
get/follow): canonical input fields now surfacereasonfrom the API (e.g.reason=rejectedwhen a stored credential was refused) instead of the removedreplace-existingmetadata.Tests cover entitlements rendering, null/unlimited handling, and the updated field formatting.
Reviewed by Cursor Bugbot for commit 8a7b363. Bugbot is set up for automated code reviews on this repo. Configure here.