Skip to content

Remove EnclosingType from operator_thunk as it is not used - #347

Merged
jbcoe merged 1 commit into
mainfrom
jbcoe-remove-enclosingtype
Sep 13, 2026
Merged

Remove EnclosingType from operator_thunk as it is not used#347
jbcoe merged 1 commit into
mainfrom
jbcoe-remove-enclosingtype

Conversation

@jbcoe

@jbcoe jbcoe commented Sep 12, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (a7726a0) to head (f71c532).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   74.38%   74.38%           
=======================================
  Files           9        9           
  Lines         890      890           
  Branches      218      218           
=======================================
  Hits          662      662           
  Misses         25       25           
  Partials      203      203
Flag Coverage Δ
consteval 96.77% <ø> (ø)
runtime 71.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philipcraig

philipcraig commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

clang-tidy fails here because the three friend struct detail::operator_thunk declarations in protocol, protocol_view and the const view still list typename EnclosingType, so clang-p2996 rejects them as redeclarations with too many template parameters. GCC accepts the mismatch silently, which is why the other jobs are green. The same failure carries through #348 to #354.

#355 already removes typename EnclosingType, from those three declarations, and that is the whole fix. Could that change move down into this PR? Otherwise clang-tidy stays red on the stack, and on main from the moment this lands until #355 does, since clang-tidy is not a required check.

The readability-implicit-bool-conversion findings on FAIL() in forwarding_test.cc are a knock-on of the compile error and disappear with it.

@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from e3a4ffd to 84663ee Compare September 12, 2026 15:11
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 84663ee to c4fbe8d Compare September 12, 2026 15:20
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from c4fbe8d to 47aefc7 Compare September 12, 2026 15:27
@jbcoe
jbcoe added this pull request to stack #359 September 12, 2026 15:29
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 47aefc7 to f2a9998 Compare September 12, 2026 15:57
@jbcoe
jbcoe removed this pull request from stack #359 September 12, 2026 16:32
@jbcoe
jbcoe added this pull request to stack #362 September 12, 2026 16:41
@jbcoe
jbcoe marked this pull request as ready for review September 12, 2026 16:49
@jbcoe
jbcoe requested a review from philipcraig September 12, 2026 16:57
@jbcoe
jbcoe removed this pull request from stack #362 September 12, 2026 22:29
@jbcoe
jbcoe added this pull request to stack #370 September 12, 2026 22:29
@jbcoe
jbcoe removed this pull request from stack #370 September 12, 2026 22:34
@jbcoe
jbcoe added this pull request to stack #371 September 12, 2026 22:46
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from f2a9998 to 9b58288 Compare September 13, 2026 13:37
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
6ccfb5c 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
f0bbc4c 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 9b58288 to 726118b Compare September 13, 2026 14:23
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
26017c2 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
70e819c 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
79a7a2d 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
67aee60 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 6cbad0a to a0507ef Compare September 13, 2026 15:37
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
283e4d8 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from a0507ef to 8b39e4d Compare September 13, 2026 15:37
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
d69a76e 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 8b39e4d to a81e872 Compare September 13, 2026 15:38
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
2d91544 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from a81e872 to 1063617 Compare September 13, 2026 15:39
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
8c2d9b5 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
Base automatically changed from jbcoe-generic-operator-thunk to main September 13, 2026 15:39
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
954d72e 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@jbcoe
jbcoe force-pushed the jbcoe-remove-enclosingtype branch from 1063617 to f71c532 Compare September 13, 2026 15:41
@jbcoe
jbcoe merged commit 59ef054 into main Sep 13, 2026
8 checks passed
@jbcoe
jbcoe deleted the jbcoe-remove-enclosingtype branch September 13, 2026 15:42
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
12b1e0c 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User
Restore anti-slicing guard on operator_overload_set
61d057f 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
75edf53 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
b9d475e 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
77bb576 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
17d09fd 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
07d0dc0 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
e7de23e 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
90f0937 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
jbcoe pushed a commit that referenced this pull request Sep 13, 2026
Test User @jbcoe
Restore anti-slicing guard on operator_overload_set
3367cc9 
e6d30c2 (#347, "Make operator_thunk generic to simplify friendship")
dropped the protected special members that stopped operator_overload_set
being sliced off through a non-view pointer, while renaming
call_operator_overload_set to the now-generic operator_overload_set.
Restore them on all four operator specialisations, and add
CallOperatorOverloadSetCannotBeDetached tests for protocol and
protocol_view alongside the existing MemberThunksCannotBeDetached ones,
covering the slicing repro from the review comment.

Addresses philipcraig's review comment on operator_thunks.hh:243 in #355.
@philipcraig philipcraig mentioned this pull request Sep 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipcraig philipcraig philipcraig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbcoe @philipcraig