[CONFIG] Lower the engines floor to Node 20.12 - #7
Open
coelhogonzalo wants to merge 1 commit into
Open
Conversation
…irement The README already documents Node 20.12+ (SecureClient needs 20, AbortSignal.any needs 20.3, process.loadEnvFile needs 20.12). engines >=24 makes engine-strict consumers fail to install the package as a dependency on Node 20/22 - notably the continue-haven fork, whose core package sets engine-strict: true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers
engines.nodefrom>=24to>=20.12, the requirement the README already documents (SecureClient needs Node 20,AbortSignal.any20.3,process.loadEnvFile20.12).Why now: the continue-haven fork adds
haven-proxyas a dependency of itscorepackage, which setsengine-strict: truewith Node>=20.20.1. Withengines >=24,npm installhard-fails there on Node 20/22.After merge, please cut a 0.5.x release tag so
github:jan3dev/haven-proxy#semver:0.xresolves to a version with this fix.