Specialize generated code to eliminate downstream Dialyzer warnings - #18
Merged
Conversation
jallum
pushed a commit
that referenced
this pull request
Sep 3, 2026
…ated reader/writer code to root-reachable schema types, precomputes vector layout, preserves union-vector error behavior, and adds a suppression-free downstream Dialyzer integration check. All PR CI jobs are green."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
The downstream fixture reproduced 21 Dialyzer errors and 10 skipped/unlexable warnings before the change. It now reports 0 errors, 0 skipped warnings, and 0 unnecessary skips with a forced PLT check.
Benchee on Elixir 1.19 / OTP 28 measured the generated decoder at 362K ips versus 143K interpreted, and the generated encoder at 94K ips versus 83K interpreted. Generated decoding retained its 19.77 KB allocation profile.
Tracks fb-3lk.