ci: Ask CodSpeed for allocation measurements too - #1697
Draft
chfast wants to merge 1 commit into
Draft
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 181 181
Lines 16199 16199
Branches 3723 3723
=======================================
Hits 15873 15873
Misses 248 248
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
ci/codspeed-memory
branch
from
September 4, 2026 13:51
55c5884 to
2f70899
Compare
The instrument is picked when the harness is compiled, not when it runs: asking the action for a mode the build was not configured for uploaded results CodSpeed found nothing in. So the mode becomes the matrix, and one Configure and one Build serve both, as the RISC-V workflow does it. Two things come along: a concurrency group, so a new push cancels the run it replaces, and the Hunter cache the other jobs already restore. Claude-Session: https://claude.ai/code/session_016UHPAGwcwXMjqhTLpT31K7
chfast
force-pushed
the
ci/codspeed-memory
branch
from
September 4, 2026 14:07
2f70899 to
4b079f3
Compare
Member
Author
|
Not worth currently for current benchmarks as memory shows at most single allocation. |
chfast
marked this pull request as draft
September 4, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An experiment, to see what CodSpeed's memory mode reports for the baseline VM.
The mode is chosen when the harness is compiled, not when it runs. The first attempt here just added
memoryto the action'smodelist against the existing simulation build: the runner accepted it, ran twice and uploaded two result sets, and CodSpeed then reported "No results found during the execution".CODSPEED_MODEtakes one value, and althoughinstrumentation,simulationandmemoryall compile to the sameCODSPEED_ANALYSIS, the memory harness behaves differently at run time — it skips the warmup and reports through the allocation hooks.So the allocation run gets a build of its own, and the two simulation runs are untouched.
Worth watching: whether the extra configure and build cost much wall time, and whether the numbers say anything the instruction counts do not.
🤖 Generated with Claude Code
https://claude.ai/code/session_016UHPAGwcwXMjqhTLpT31K7