Feature/signal value format registry - #697
Conversation
| import 'package:rohd_devtools_widgets/rohd_devtools_widgets.dart'; | ||
|
|
||
| void main() { | ||
| test('formats bare binary and hexadecimal waveform values', () { |
There was a problem hiding this comment.
some of these are surprising to me. How does it know 11111111 is binary and not decimal or hex? how does it know ff is hex?
There was a problem hiding this comment.
I'm now using LogicValue to help interpret values and convert them. In the case above, the length was the helper to disambiguate.
| import 'package:rohd_devtools_widgets/rohd_devtools_widgets.dart'; | ||
|
|
||
| void main() { | ||
| test('formats bare binary and hexadecimal waveform values', () { |
There was a problem hiding this comment.
some of these are surprising to me. How does it know 11111111 is binary and not decimal or hex? how does it know ff is hex?
There was a problem hiding this comment.
I'm now using LogicValue to help interpret values and convert them. In the case above, the length was the helper to disambiguate.
| SignalValueFormatRegistry._(); | ||
|
|
||
| /// Current occurrence-format preferences. | ||
| static final formats = ValueNotifier<Map<String, String>>( |
There was a problem hiding this comment.
why aren't we using enums for the different supported types?
| ); | ||
| }); | ||
|
|
||
| test('looks up a uniquely matching hierarchy suffix', () { |
There was a problem hiding this comment.
i'm confused why these non-matching things should match? it always matches any suffix?
2 participants
Description & Motivation
This is a dependency needed as central for widgets to communicate changes in the way a signal value is displayed.
Related Issue(s)
None.
Testing
This feature is used in future widgets where testing is performed, but not introduced yet. But basic testing for store/recall of format is performed.
Backwards-compatibility
No.
Documentation
No, not yet. This is a narrow dependency needed to introduce future widgets.