[pinocchio.Gripper] change name from getter to property. - #180
Merged
Conversation
For consistency with manipulation.Handle.name.
for more information, see https://pre-commit.ci
nim65s
reviewed
Aug 21, 2026
nim65s
left a comment
nim65s
left a comment
Member
There was a problem hiding this comment.
I believe an exception would be better than an easily missed message on stderr
Contributor
Author
|
But an exception will break users' code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with manipulation.Handle.name. A warning message is delivered in std::cerr when the deprecated getter is called.