Harden horizontal scroll offsets - #2103
Conversation
Spliced out from htop-dev#2099
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthrough
Suggested reviewers: Severity of issue fixed: Low Merge Risk: 🟡 Moderate · up to Right-arrow navigation can overflow or calculate an incorrect horizontal bound for exceptionally large rendered values because the offset is incremented before clamping. The arithmetic should be made overflow-safe before merge. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Left scroll stops at zero Comment |
Spliced out from #2099
This makes htop only scroll right if there is something to scroll right to.