Conversation
Contributor
Author
|
wtf Codex stole my authorship |
LPTK
reviewed
Sep 21, 2026
| mono: Bool, | ||
| nonAffineTracking: Bool, | ||
| accumulatorTracking: Bool, | ||
| )(using TraceLogger, Elaborator.State, Raise, SymbolPrinter): FlowConstraintSolver = |
Contributor
|
Thanks! As discussed,
|
LPTK
reviewed
Sep 21, 2026
| val fStrat = processResult(f) | ||
| val argsStrat = args.map(a => processResult(a.value)) | ||
| if args.exists(_.spread.isDefined) then | ||
| // TODO: preserve callee-effect precision for spread calls without modeling their argument flow. |
LPTK
reviewed
Sep 21, 2026
| cc.constrain(effect, enclosingEffect) | ||
| effect | ||
| def constrainConstructorEffect(result: Result): Unit = | ||
| val mayRaise = result match |
Contributor
There was a problem hiding this comment.
Suggested change
| val mayRaise = result match | |
| val mayHaveSideEffects = result match |
LPTK
reviewed
Sep 21, 2026
| if config.liftDefns.isDefined then | ||
| blockPass(Lifter(_).transform)(prog) | ||
| else prog | ||
| runPass("EffectAnalysis"): prog => |
LPTK
marked this pull request as draft
September 21, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This artifact is endorsed by Anto