Skip to content

Fix warnings - #428

Closed
ankane wants to merge 1 commit into
hashicorp:masterfrom
ankane:fix-warnings
Closed

ankane wants to merge 1 commit into
hashicorp:masterfrom
ankane:fix-warnings

Conversation

@ankane

@ankane ankane commented Sep 22, 2026

Copy link
Copy Markdown

Hi, this PR fixes warnings when Ruby warnings are enabled.

ruby -W -e 'require "vault"'
/home/user/.rbenv/versions/4.0.7/lib/ruby/gems/4.0.0/gems/vault-0.20.1/lib/vault/client.rb:4: warning: CGI library is removed from Ruby 4.0. Please use cgi/escape instead for CGI.escape and CGI.unescape features.
If you need to use the full features of CGI library, Please install cgi gem.
/home/user/.rbenv/versions/4.0.7/lib/ruby/gems/4.0.0/gems/vault-0.20.1/lib/vault/api/logical.rb:150: warning: assigned but unused variable - e
/home/user/.rbenv/versions/4.0.7/lib/ruby/gems/4.0.0/gems/vault-0.20.1/lib/vault/api/sys/mount.rb:127: warning: assigned but unused variable - json

@ankane
ankane requested a review from a team as a code owner September 22, 2026 01:35
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@ankane ankane closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant