security: restrict repository clone transports - #6
Open
harshitethic wants to merge 4 commits into
Open
harshitethic wants to merge 4 commits into
harshitethic wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/api/runpassed caller-controlledrepo_urldirectly togit clone. Git accepts more than normal HTTPS remotes, including local filesystem paths,file://URLs, SSH/scp-style remotes, and other transports. That widened PatchPilot's clone boundary beyond the web-repository workflow documented by the product and could let an API caller make the backend read from local Git repositories or invoke unintended remote transports.Solution
file://, SSH/scp syntax, plain HTTP, embedded credentials, localhost/private IP literals, and query/fragment inputsSecurity scope
This closes local/non-HTTPS clone transports and obvious local-network literals. It is not a complete SSRF sandbox: a hostname can still resolve to internal infrastructure, and cloned repository code can execute through approved test tooling. Strong isolation still requires network/process sandboxing or an explicit repository-host allowlist.
Validation
python -m compileall -q app testspassed.python -m unittest discover -s tests -v— 30 tests passed.git diff --checkpassed on the resolved integration.Backend CIrun #12 passed on final head616c72255ebdf8fab943a15ea8576f7edb16bfaffor Python 3.11 and 3.12.Integration state
PR #5 landed first and changed the same backend/test files. This branch now explicitly contains both workspace path containment and repository transport validation, GitHub reports the PR as mergeable, and final CI is green.
AI assistance disclosure: AI assistance was used to identify the clone-transport boundary, implement the focused validation, add regression tests, resolve the post-#5 integration conflict, run validation, review the resulting diff, and inspect CI state.