ci: guard against split effect version in lockfile - #360
Closed
jack-champagne wants to merge 1 commit into
Closed
jack-champagne wants to merge 1 commit into
jack-champagne wants to merge 1 commit into
Conversation
effect + @effect/* are lockstep-versioned; a second, unpinned effect pulled transitively (hono-openapi -> @standard-community/*) can silently coexist in bun.lock and crash at runtime in Schema.toJsonSchemaDocument with 'undefined is not an object (evaluating a.name)', nondeterministically by build. Add a fast lockfile assertion in the unit job that fails when bun.lock resolves more than one effect version. Depends on the effect-dedupe fix (single effect@4.0.0-beta.83) landing first; this guard fails on the current split lock by design.
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Closing alongside #359 — targets the deprecated harmoniqs/opencode. The single-effect-version CI guard will be re-proposed in harmoniqs/amicode if wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a fast lockfile assertion to the
unitjob intest.yml: fail CI ifbun.lockresolves more than oneeffect@version.Why
effectand@effect/*are lockstep-versioned. A second, unpinnedeffectpulled transitively (e.g.hono-openapi→@standard-community/standard-json/standard-openapi, whoseeffect: ^3.xpeer floats to a different beta) silently coexists inbun.lock. Whichever copy the bundler wires intoSchema.toJsonSchemaDocument(tool params → JSON schema) then decides whether a given build crashes on every prompt with:This is invisible to install/typecheck and nondeterministic by build — exactly what shipped broken in a recent dev binary. This guard makes the split fail loudly in CI.
Dependency / ordering
effect@4.0.0-beta.83viaoverrides) before/with this, or CI here will be red until the lock is deduped.Follow-up considered, not included
@effect/*matcheffectexactly (stronger, more code) — deferred.upstream-sync.ymlauto-merges 'bun.lock theirs + bun install' weekly, which is the real recurrence vector; theoverridespin survives that (it's in package.json), and this guard will catch any regression it introduces.