Skip to content

Pre-push typecheck gate fails on base: settings-v2/skills.tsx badge props #367

Description

@aarontrowbridge

The pre-push hook runs the monorepo typecheck, which fails on base (local/amicode @ d377077):

@opencode-ai/app:typecheck: src/components/settings-v2/skills.tsx(124,31): error TS2322: Type '"secondary"' is not assignable to type '"contrast" | 'danger' | 'ghost' | 'ghost-muted' | 'loading' | 'neutral' | 'outline' | 'warning' | undefined'.
@opencode-ai/app:typecheck: src/components/settings-v2/skills.tsx(142,23): error TS2322: Type '"xs"' is not assignable to type '"large" | 'normal' | 'small' | undefined'.
@opencode-ai/app:typecheck: src/components/settings-v2/skills.tsx(143,23): error TS2322: Type '"secondary"' is not assignable …

Impact: every push from a fresh worktree/clone fails the gate (fresh turbo cache runs the broken package); PR #366 had to use --no-verify. Anyone with a warm turbo cache pushes green — the gate is currently verifying cache state, not the tree.

The offending secondary/xs usages are present in the base file, and the UI package's prop unions don't accept them — either the badge grew narrower or skills.tsx never typechecked against it. Quick fix PR available on request: align skills.tsx to the union (or widen the union intentionally).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions