test(engine): fix connections test hermeticity + wire unit-test lane (#1233) - #1238
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
marked this pull request as ready for review
September 16, 2026 18:07
jeonghun-jj-lee
force-pushed
the
1228-engine-test-ci
branch
2 times, most recently
from
September 16, 2026 18:49
34b891a to
2cde230
Compare
…t lane (#1233) Restore the final #1233 state cleanly on main after #1235 merged: - fix the connections-suite hang by redirecting every token credential path (AMICO_SLACK/GITHUB/LINEAR/GOOGLE/GOOGLE_DRIVE_FILE) into each test tmpdir; real ~/.amico credentials no longer leak a second background revalidation. - quarantine the one legacy-lineage spec conflict (it.instance.skip, #1239), leaving the other 22 session tests active. - add engine_test_gate.sh plus `pnpm test:engine:unit` / AGENTS.md docs. - run the unit suite after the required typecheck gate as a non-blocking CI lane. The suite reports on every main PR; promote it to required after #1239 hardens pollution, timing flakiness, and positive cross-test dependencies. - preserve #1235's contents:read and persist-credentials:false security hardening and main-only CI trigger. The runtime base-drift recorded test remains excluded under #1229. Refs #1233, #1239, #1229
jeonghun-jj-lee
force-pushed
the
1233-engine-test-lane
branch
from
September 16, 2026 19:08
4473614 to
41914bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the engine unit-test lane + fix test hermeticity (#1233)
Stacked on #1235 (
1228-engine-test-ci). Merge #1235 first (or rebase this ontodevafter it lands).What ships
The engine gets its unit tests running in CI for the first time since the fork
absorption (#1114), alongside the #1228 typecheck gate — in the same
engine-testsjob (materialize →
bun install→ typecheck → unit tests).bun turbo test),NON-BLOCKING (
continue-on-error) until the suite is hardened (Session-lineage spec conflict: legacy-parent aggregation vs 'Bug A fix' (auto-create) — tied to server-survives-rebuild #1239). Latest run:3754 pass, 2 fail, 17 skip in ~5 min — it reports in the logs without gating.
The real fix: test hermeticity (the hang)
The unit suite couldn't run at all because it hung. Root cause was a hermeticity
bug: the connections suites redirected only
AMICO_CLOUD_FILE/AMICO_PASQAL_FILE,but token connections (
slack/github/linear/google/google-drive, #327)resolve their credential files via
AMICO_*_FILEtoo — so a host's real~/.amico/slack.jsonleaked in, fired a second background revalidate, and hungafterEach. Fixed by redirecting all five into the per-test tmp dir in bothamicode-connections.test.tsandamicode-connections-routes.test.ts(118 testspass; the suite now completes instead of hanging).
Why the lane is non-blocking (not my call to fix here)
Once running, a clean CI runner showed the suite has systemic instability — none
of it caused by this change, all pre-existing and never CI-gated:
header-timeoutchunkTimeout — passes locally, fails on slower CI),amicode-release-workflow— fails when isolated),session.test.ts"keeps legacyparents outside aggregation" contradicts
session-diff-scoped.test.ts:1462's"Bug A fix" auto-create — likely tied to server-survives-rebuild (Session-lineage spec conflict: legacy-parent aggregation vs 'Bug A fix' (auto-create) — tied to server-survives-rebuild #1239,
it.instance.skip, the other 22 session tests still run).Making the lane a green required gate needs broad suite hardening (#1239),
deliberately out of scope. Flip
continue-on-erroroff once #1239 lands.Follow-ups
adjudicate the legacy-parent lineage spec conflict → then make the lane required.
llm-native-recorded.test.tshere; also ownsthe 3 typecheck-allowlist entries).
Refs #1233, #1239, #1229, #1228.