Skip to content

Move one simplification call in lowering. - #9355

Open
mcourteaux wants to merge 2 commits into
mcourteaux/llvm21-load-elim-workaroundfrom
mcourteaux/move-simplify
Open

Move one simplification call in lowering.#9355
mcourteaux wants to merge 2 commits into
mcourteaux/llvm21-load-elim-workaroundfrom
mcourteaux/move-simplify

Conversation

@mcourteaux

@mcourteaux mcourteaux commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

When debugging some stuff not part of this PR, I spotted a missing simplification, which Andrew determined to be AFTER hoist_loop_invariant_xxx. This moves the simplification in the right spot.

Breaking changes

I hope none, let's see.

These do not necessarily disqualify a PR from being merged, but they should at
least be tagged with the release_notes label.

Checklist

  • Tests added or updated (not required for docs, CI config, or typo fixes)
  • Documentation updated (if public API changed)
  • Python bindings updated (if public API changed)
  • Benchmarks are included here if the change is intended to affect performance.
  • Commits include AI attribution where applicable (see Code of Conduct)

Comment thread src/Lower.cpp Outdated
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.05%. Comparing base (7c72fc2) to head (6049eb3).

Files with missing lines Patch % Lines
src/Lower.cpp 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           mcourteaux/llvm21-load-elim-workaround    #9355      +/-   ##
==========================================================================
+ Coverage                                   69.99%   70.05%   +0.05%     
==========================================================================
  Files                                         261      261              
  Lines                                       79231    79231              
  Branches                                    19313    19313              
==========================================================================
+ Hits                                        55461    55507      +46     
+ Misses                                      17938    17926      -12     
+ Partials                                     5832     5798      -34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexreinking

Copy link
Copy Markdown
Member

Deadlocks exposed here fixed by #9372

@mcourteaux
mcourteaux force-pushed the mcourteaux/move-simplify branch from 34b2370 to 84cc3b3 Compare August 21, 2026 07:45
@mcourteaux

mcourteaux commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Waiting for #9372 to land to update this branch, but this seems to work now.

@abadams please take note of Claude's initiative to disable a lower pass in LLVM 21, due to a bug fixed in 22 regarding SVE on ARM. I'll open a PR separately for this LLVM pass skip and remove the skips in all the tests to see if that makes the test suite pass.

@abadams

abadams commented Aug 24, 2026

Copy link
Copy Markdown
Member

Looks like it needs to be rebased. A bunch of unrelated changes are in it now.

@alexreinking
alexreinking force-pushed the mcourteaux/move-simplify branch 2 times, most recently from 00a65a3 to a00b0ef Compare August 24, 2026 19:37
@alexreinking
alexreinking changed the base branch from main to mcourteaux/llvm21-load-elim-workaround August 24, 2026 20:21
@alexreinking
alexreinking force-pushed the mcourteaux/move-simplify branch from a00b0ef to 6049eb3 Compare August 24, 2026 20:21
mcourteaux and others added 2 commits August 26, 2026 09:09
Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com>
@mcourteaux
mcourteaux force-pushed the mcourteaux/move-simplify branch from 6049eb3 to b8fd264 Compare August 26, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants