Dialyzer cleanup - #52
Merged
Merged
Conversation
ziopio
force-pushed
the
ziopio/cleanup
branch
2 times, most recently
from
September 11, 2026 10:20
09d0a5a to
92e0971
Compare
ziopio
force-pushed
the
ziopio/cleanup
branch
from
September 11, 2026 10:28
cde5e84 to
660f04c
Compare
maehjam
reviewed
Sep 11, 2026
| edifa_opts(State) -> | ||
| edifa_opts(State, #{}). | ||
| #{ | ||
| log_handler => fun edifa_log_hanler/2, |
Member
There was a problem hiding this comment.
Is there a typo "edify_log_handler"?
Member
Author
There was a problem hiding this comment.
it is edifa_log_hanler ...
Member
There was a problem hiding this comment.
LOL made another typo in the correction. "edifa_log_handler". (Actually autocorrect does not like the word "edifa".)
Member
There was a problem hiding this comment.
What is a hanler? I mean it seems to be the name of the function, but this clearly looks like a typo.
maehjam
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialyzer did find usages of rebar modules in this repo, that are important to remove since this is used also by Mix/Elixir libs