fix(settings): even out spacing around the settings separator - #1225
Draft
makhnatkin wants to merge 1 commit into
Draft
fix(settings): even out spacing around the settings separator#1225makhnatkin wants to merge 1 commit into
makhnatkin wants to merge 1 commit into
Conversation
The `margin: 0 2px` on the preview button is left over from the layout that also had a mode button (#207); after the mode button was dropped (#933) it only made the separator sit 6px from the preview button and 4px from the settings button. The separator was also rendered on a truthy `settingsVisible`, so an empty `settingsVisible={[]}` produced a divider with no settings button next to it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR fixes settings-toolbar alignment by removing a leftover preview-button margin and prevents an orphaned divider by using the same visibility condition as the settings button. Toolbar screenshots will need regeneration; settings-panel snapshots are unaffected. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The divider between the preview button and the settings button is off-center: 6px on one side, 4px on the other.
The cause is a
margin: 0 2pxon the preview button, left over from the old settings block layout that also had a mode button next to it (#207). The mode button was moved into the popup in #933, the margin stayed. Removing it makes the divider symmetric.Also fixes a divider that could hang on its own: it was rendered on a truthy
settingsVisible, while the settings button itself usesareSettingsVisible. WithsettingsVisible={[]}that meant a divider with no button after it.Draft: toolbar screenshots shift by a few pixels and still need to be regenerated (
playwright:docker:update --grep 'Toolbar'). The settings panel snapshots capture the popup only and are unaffected.🤖 Generated with Claude Code
Summary by Sourcery
Fix settings toolbar divider alignment and visibility.
Bug Fixes: