cmd/fscrypt: accept non-ASCII mountpoints in MOUNTPOINT:ID flags - #460
Open
rootkiller6788 wants to merge 1 commit into
Open
cmd/fscrypt: accept non-ASCII mountpoints in MOUNTPOINT:ID flags#460rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
The idFlagRegex only allowed ASCII printable characters in the mountpoint portion, so flags like --protector=/mnt/miroir-données:d77aa788ff9d1931 were rejected even though the filesystem path is valid. Use a character class that accepts any non-control Unicode character instead. Fixes google#446
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446.
The
MOUNTPOINT:IDflag regex (idFlagRegexin cmd/fscrypt/flags.go) matched the mountpoint with[[:print:]], which in Go's regexp is ASCII-only. As a result, flags such as--protector=/mnt/miroir-données:...or--policy=/mnt/naïve:...were rejected with "does not have format MOUNTPOINT:ID", even thoughsetupaccepts the same mountpoint as a positional argument.This change matches the mountpoint with
[^\p{Cc}](any non-control Unicode character), which is a strict superset of the old ASCII printable set. The descriptor group is unchanged ([[:alnum:]]+), and malformed values (missing separator, empty descriptor, control characters) are still rejected.Verified locally on Linux:
go build ./...,go test ./...(all packages pass),go vet,staticcheck, andgofmt/goimportsare clean.