Avoid type identity comparison in ASTHelpers.isSubtype - #6087
Merged
Conversation
Check `t.tsym == state.getSymtab().unknownSymbol` instead of comparing `t == state.getSymtab().unknownType` by identity. `UnknownType` became an `ErrorType` in JDK 24+ (JDK-8339296), but had `TypeTag.UNKNOWN` in earlier JDKs; comparing `tsym` avoids type identity issues across JDK versions. PiperOrigin-RevId: 975827572
copybara-service
Bot
force-pushed
the
test_975749473
branch
from
September 3, 2026 18:18
dd1a14b to
aa37745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid type identity comparison in
ASTHelpers.isSubtypeCheck
t.tsym == state.getSymtab().unknownSymbolinstead of comparingt == state.getSymtab().unknownTypeby identity.UnknownTypebecame anErrorTypein JDK 24+ (JDK-8339296), but had
TypeTag.UNKNOWNin earlier JDKs; comparingtsymavoids type identity issues across JDK versions.