Skip to content

Fix non App Engine imports - #5435

Merged
ViniciustCosta merged 1 commit into
google:masterfrom
notvictorl:liuvic/fix-imports
Aug 25, 2026
Merged

Fix non App Engine imports#5435
ViniciustCosta merged 1 commit into
google:masterfrom
notvictorl:liuvic/fix-imports

Conversation

@notvictorl

@notvictorl notvictorl commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Recent changes to imports on clusterfuzz._internal.bot are causing 500 failures since clusterfuzz._internal.bot is excluded from App Engine context. 4140da0

Fixing clusterfuzz._internal.bot imports to be function-level instead of file-level.

b/552012304

@notvictorl
notvictorl requested a review from a team as a code owner August 24, 2026 19:38
@notvictorl
notvictorl requested a review from dylanjew August 24, 2026 19:39

@dylanjew dylanjew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to repro the bug before and after you push this PR to dev?

@notvictorl

Copy link
Copy Markdown
Collaborator Author

Are you able to repro the bug before and after you push this PR to dev?

Yeah, I can try this on dev (and intentionally break dev for a short bit)

@ViniciustCosta ViniciustCosta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting the changes!

Since this issue hit production, I assume you weren't able to test #5387 in dev? If so, could you try to do it?

@notvictorl

Copy link
Copy Markdown
Collaborator Author

Okay tested on dev and this change fixes the issue of the previous import changes. dev went from 500 error like production back to working.

397ea89

@dylanjew dylanjew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for testing this!

@ViniciustCosta

Copy link
Copy Markdown
Collaborator

Okay tested on dev and this change fixes the issue of the previous import changes. dev went from 500 error like production back to working.

397ea89

Thanks!

However, what I meant was testing in dev the actual intended changes (the build-related changes) of that PR and verify if they are working as expected. I will merge this to ensure master is not broken, but it would be great if you could check that before the next release :)

@ViniciustCosta
ViniciustCosta merged commit c220927 into google:master Aug 25, 2026
15 checks passed
@notvictorl
notvictorl deleted the liuvic/fix-imports branch August 25, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants