Fix non App Engine imports - #5435
Conversation
dylanjew
left a comment
There was a problem hiding this comment.
Are you able to repro the bug before and after you push this PR to dev?
Yeah, I can try this on dev (and intentionally break dev for a short bit) |
ViniciustCosta
left a comment
There was a problem hiding this comment.
Thanks for reverting the changes!
Since this issue hit production, I assume you weren't able to test #5387 in dev? If so, could you try to do it?
|
Okay tested on dev and this change fixes the issue of the previous import changes. dev went from 500 error like production back to working. |
dylanjew
left a comment
There was a problem hiding this comment.
thanks for testing this!
Thanks! However, what I meant was testing in dev the actual intended changes (the build-related changes) of that PR and verify if they are working as expected. I will merge this to ensure master is not broken, but it would be great if you could check that before the next release :) |
Recent changes to imports on
clusterfuzz._internal.botare causing 500 failures sinceclusterfuzz._internal.botis excluded from App Engine context. 4140da0Fixing
clusterfuzz._internal.botimports to be function-level instead of file-level.b/552012304