feat(tools): let toolsets replace a failed tools listing - #6749
Open
a2105z wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Apps fronting per-user OAuth MCP servers need a seam to contribute placeholder tools on HTTP 401 instead of the framework silently dropping the toolset. Add BaseToolset.on_tools_listing_error and invoke it from the agent and SkillToolset isolate-and-continue paths.
a2105z
force-pushed
the
feat/toolset-listing-failure-hook
branch
from
August 16, 2026 14:26
bb41cc5 to
5a342a6
Compare
Contributor
Author
|
@googlebot I fixed it. |
varunbiluri
reviewed
Aug 16, 2026
varunbiluri
left a comment
varunbiluri
left a comment
There was a problem hiding this comment.
Staff review: one prefix-contract issue to address.
Keep the BaseToolset naming contract on the isolate-and-continue path by routing listing-error replacements through the shared prefix helper.
Contributor
Author
|
@varunbiluri addressed your prefix-contract note in the latest push — thank you again for the staff review. Please take another look when you have a chance, and let me know if there’s anything else you’d like changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseToolset.on_tools_listing_errorso apps can contribute replacement tools when listing fails (default: empty list / current skip behavior)LlmAgenttool loading andSkillToolsetadditional-tool resolution after the existing isolate-and-continue loggingFixes #6748
Test plan
pytest tests/unittests/tools/test_base_toolset.py(default + override hook)pytest tests/unittests/agents/test_llm_agent_fields.py -k canonical_toolspytest tests/unittests/tools/test_skill_toolset.py -k resolution_get_tools()/get_tools_with_prefix()calls (exceptions still propagate there)