Skip to content

Fix falsy HTTP port defaults - #148

Merged
noise64 merged 3 commits into
mainfrom
fix/npm-empty-http-port
Sep 8, 2026
Merged

Fix falsy HTTP port defaults#148
noise64 merged 3 commits into
mainfrom
fix/npm-empty-http-port

Conversation

@noise64

@noise64 noise64 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor
  • resolves https://linear.app/golem-cloud/issue/GOL-550
  • matches Node.js v22.14 HTTP request normalization by treating falsy numeric/coercible port inputs as absent while preserving the explicit string port "0"
  • falls back through the configured request or agent default port before the HTTP/HTTPS protocol default
  • adds focused runtime coverage for HTTP and HTTPS defaults, custom defaults, and falsy port variants, plus the generated export declaration
  • refreshes the stale generated Node compatibility summary inherited from main
  • validated by full review and focused P2/P3 runtime, report-currentness, and generated-definition checks

Node compatibility

  • runnable configuration and classifications are unchanged
  • generated primary CI-enforced summary: 3177/4387 (72.4%)3180/4387 (72.5%)
  • generated full-public summary: 3177/5750 (55.3%)3180/5750 (55.3%)
  • the count change corrects the report already implied by the inherited configuration; it does not enable three tests in this PR
  • the covered port cases match the observed Node.js v22.14 behavior

@blacksmith-sh

This comment has been minimized.

@blacksmith-sh

This comment has been minimized.

@noise64
noise64 marked this pull request as ready for review September 8, 2026 13:45
@noise64
noise64 merged commit 9c5032e into main Sep 8, 2026
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant