test(normalizer): fix the escaped-path base case failing on windows - #309
Merged
fredbi merged 1 commit intoAug 25, 2026
Merged
Conversation
TestNormalizer_CanonicalBase/escaped_path_rendering expected normalizeBase("%2F")
to be "file:///". A base carrying no scheme is anchored to the working directory,
so on windows it comes out as "file:///d:", or whichever drive the tests run from.
The case moves out of the table into TestNormalizer_EscapedPathRendering, which
compares normalizeBase("%2F") against normalizeBase("/") rather than a literal:
both spell the root and both are anchored the same way, on either platform. It
also asserts what the defect actually was, that the result is neither
"file://%2F" nor something parseURL rejects.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
=========================================
Coverage ? 93.03%
=========================================
Files ? 30
Lines ? 2512
Branches ? 0
=========================================
Hits ? 2337
Misses ? 175
Partials ? 0 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNormalizer_CanonicalBase/escaped_path_rendering expected normalizeBase("%2F") to be "file:///". A base carrying no scheme is anchored to the working directory, so on windows it comes out as "file:///d:", or whichever drive the tests run from.
The case moves out of the table into TestNormalizer_EscapedPathRendering, which compares normalizeBase("%2F") against normalizeBase("/") rather than a literal: both spell the root and both are anchored the same way, on either platform. It also asserts what the defect actually was, that the result is neither "file://%2F" nor something parseURL rejects.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist