fix(workflows): validate dispatch defaults - #4181
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Validates workflow dispatch defaults before initial execution.
Changes:
- Preserves malformed defaults for validation.
- Adds shape validation and pre-execution safeguards.
- Adds validation and execution tests.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/workflows/engine.py |
Adds default validation and execution guard. |
tests/test_workflows.py |
Covers valid, invalid, and null defaults. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+993
to
+995
| dispatch_default_errors = _dispatch_default_errors(definition) | ||
| if dispatch_default_errors: | ||
| raise ValueError(" ".join(dispatch_default_errors)) |
mnriem
requested changes
Aug 18, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback and fix test & lint errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification