Skip to content

unified: Disable build on linux-arm64 - #22373

Open
asgerf wants to merge 1 commit into
mainfrom
unified/disable-arm64-build
Open

unified: Disable build on linux-arm64#22373
asgerf wants to merge 1 commit into
mainfrom
unified/disable-arm64-build

Conversation

@asgerf

@asgerf asgerf commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@asgerf asgerf added the no-change-note-required This PR does not need a change note label Aug 18, 2026
@asgerf
asgerf force-pushed the unified/disable-arm64-build branch from 986c534 to f499e73 Compare August 18, 2026 13:15
@asgerf
asgerf marked this pull request as ready for review August 18, 2026 14:50
@asgerf
asgerf requested a review from a team as a code owner August 18, 2026 14:50
@asgerf
asgerf requested review from jketema and a balanced review from Copilot August 18, 2026 14:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes unified extractor packaging platform-aware, disabling the real extractor on Linux ARM64.

Changes:

  • Uses codeql_platform_select.
  • Routes Linux ARM64 to the unsupported-platform fallback.
  • Restricts Swift runtime libraries to Linux x64.
Show a summary per file
File Description
unified/BUILD.bazel Selects extractor binaries and runtime files by platform.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread unified/BUILD.bazel
"//unified/extractor",
"//unified/swift-syntax-rs:swift_runtime_libs",
],
linux_arm64 = ["//unified/extractor-unsupported-os:extractor"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We indeed might want to update the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants