Conversation
NickAnge
marked this pull request as ready for review
September 23, 2026 15:32
Author
|
I openend it for review but i think i this should be written on top of #5464. Once this is merged, i will rebase it |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSM housekeeper deletes stale runner tokens/JIT configurations individually, consuming one API request per parameter and contributing to throttling and cleanup backlogs. Delete up to 10 names per
DeleteParametersrequest instead: 1,000 eligible parameters require 100 delete calls rather than 1,000, excluding retries.Wait 350 ms before each batch to pace an invocation below the default three delete requests per second. Retain SDK retries and continue after exhausted batch failures, logging the affected names and any
InvalidParametersreturned by SSM. Account/Region quotas are shared, so simultaneous housekeepers can still throttle. Existing age filtering and dry-run behavior are preserved.Both housekeeper IAM policies now grant
ssm:DeleteParameters. Documentation covers cleanup behavior and the need to deploy the IAM update alongside the Lambda. This change is based on main and leaves listing behavior unchanged; page-by-page cleanup in #5464 and native expiration policies in #5265 are complementary work.Related: #5243.
Tests added/updated (mocked SSM):
Validation:
tsc --noEmitcheck reports errors in untouched tests and Vitest configuration files.No AWS deployment or live parameter deletion was performed.