Waldorf Quantum/Iridium: write up to four layers, the layout of the MK2 generation - #427
Merged
Merged
Conversation
douglas-carmichael
force-pushed
the
qpat-four-layers
branch
8 times, most recently
from
September 15, 2026 02:55
2688363 to
23ad0be
Compare
douglas-carmichael
added a commit
to douglas-carmichael/ConvertWithMoss
that referenced
this pull request
Sep 15, 2026
…es (daily driver 2026-09-14b) The label of the layers option was created but never added to the pane. The drop-down now comes from the panel with its label, like the other drop-downs and without a tooltip, the option is called 'Maximum number of layers' and its choices are short enough for the pane: '1 layer', '2 layers', '3 layers (MK2 only)', '4 layers (MK2 only)'. Same change as the amended commit of PR git-moss#427. Claude-Session: https://claude.ai/code/session_01P2bmFi6STyJoKHvjkuLiVy
…K2 generation The 'Use a second layer' check box becomes a 'Maximum number of layers' drop-down with 1, 2, 3 or 4 layers. With 3 or 4, a source with more than 6 groups is written with up to 9 or 12 multi-samples in the layout the Iridium MK2 stores its own patches in: the layer count 2, the format version 15 and always four stored layers, of which the unused ones are switched off (LayerActive 0, no oscillators, no maps). The loader of the device clears the file offsets of the layers 3 and 4 in files up to the version 14, which is why the layout needs the version 15. Only as many layers as the groups need are used, so a source with up to 6 groups is still written as the 2-layer patch of the version 14 which every instrument of the family plays. The samples of all later layers are named in the first layer for the importer of the device. A setting of the old option is taken over, and the old command line parameter is still accepted. Verified on an Iridium MK2 with OS 4.0.6: a written 4-layer patch with one sample pitch per layer plays all four pitches, a 3-layer patch with its switched-off fourth layer plays its three. Claude-Session: https://claude.ai/code/session_01P2bmFi6STyJoKHvjkuLiVy
douglas-carmichael
force-pushed
the
qpat-four-layers
branch
from
September 15, 2026 17:50
23ad0be to
aec7e24
Compare
douglas-carmichael
added a commit
to douglas-carmichael/ConvertWithMoss
that referenced
this pull request
Sep 15, 2026
…b): PRs git-moss#427 and git-moss#428 rebased onto upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #426 and #425 and rebased on main (it needs the entries which name the samples of the later layers in the first layer); the diff shows all three until those land.
The 'Use a second layer for more than 3 groups' check box becomes a Maximum number of layers drop-down with 1, 2, 3 or 4 layers (
-p QPATLayers=1|2|3|4on the command line; a stored setting and the old parameter of the check box are taken over). The drop-down is built like the other ones of the settings panes, with its label. With 3 or 4, a source with more than 6 groups is written with up to 9 or 12 multi-samples in the layout the Iridium MK2 stores its own patches in: the layer count 2 at offset 428, the format version 15 and always four stored layers, of which the unused ones are switched off -LayerActive0, no oscillators, no sample maps - exactly like the 304 version-15 files of the corpus, which store four layers for every dual-layer patch. The loader of the device clears the file offsets of the layers 3 and 4 in files up to the version 14 and checks the offsets of all four layers when it loads a count-2 file, which is why the layout needs the version 15 and the two extra blobs.Only as many layers as the groups need are used, so a source with up to 6 groups is still written as the 2-layer patch of the version 14 which every instrument of the family plays; a 4-group source gives a byte-identical file to the one the check box produced. The samples of all later layers are named in the first layer for the importer of the device (#426).
Checked: