feat(taskworker): Add child fetch wait duration metric - #787
Merged
Conversation
lvthanh03
approved these changes
Aug 27, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
taskworker.worker.child.fetch_wait_durationdistribution metric of how long each child blocks inchild_tasks.get()waiting for work.Question we'd like to answer:
When a child is idle, is it because the parent has nothing to give it, or because it can't get at work that's already sitting in the queue?
In
process-segments-push(s4s2), children are idle ~55% of the time whilechild_tasks.sizeaverages 8.97. Aget()on a queue that deep should return in quickly. We can't currently tell which of those is wrong.Existing metrics don't answer it.
child_task_queue_emptyonly fires after a full 1s timeout, so it counts famines and misses the normal case. Occupancy gives the aggregate but not the shape, and the shape is what identifies the cause:child_tasks.size> 0_rlockcontention, children serializing on one queue lockThat distinction decides how to update the autoscaling metric