ref(types): Move sampling types to dedicated module - #1312
Draft
szokeasaurusrex wants to merge 1 commit into
Draft
ref(types): Move sampling types to dedicated module#1312szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
Move `SampleRand` and `InvalidSampleRandError` from `protocol/v7.rs` into a new private top-level `sampling` module, re-exported from the old `protocol::v7` path, so the public API is unchanged. This is primarily code motion without any behavioral changes; the only non-mechanical edits are the imports the new module needs (`serde`, `thiserror`, and some `std::fmt`/`std::str` items). This prepares the module for upcoming sampling work related to propagating the sampling seed (`sample_rand`) with traces. References [#735](#735) References [RUST-1](https://linear.app/getsentry/issue/RUST-1)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sentry-types-sampling-module
branch
from
September 4, 2026 12:45
97b5fcb to
6b40262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
SampleRandandInvalidSampleRandErrorfromprotocol/v7.rsinto a new private top-levelsamplingmodule, re-exported from the oldprotocol::v7path, so the public API is unchanged. This is primarily code motion without any behavioral changes; the only non-mechanical edits are the imports the new module needs (serde,thiserror, and somestd::fmt/std::stritems).This prepares the module for upcoming sampling work related to propagating the sampling seed (
sample_rand) with traces.References #735
References RUST-1