Skip to content

test(android): Add GradleTestKit tests for sentry.gradle.kts asset tasks - #6754

Open
antonis wants to merge 1 commit into
al/fix-gradle-modules-generated-assetsfrom
al/gradle-asset-tasks-tests
Open

test(android): Add GradleTestKit tests for sentry.gradle.kts asset tasks#6754
antonis wants to merge 1 commit into
al/fix-gradle-modules-generated-assetsfrom
al/gradle-asset-tasks-tests

Conversation

@antonis

@antonis antonis commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Tests

📜 Description

Adds test for PRs #6751 and #6753

💡 Motivation and Context

Closes #6752

💚 How did you test it?

  • CI

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

@antonis @claude
test(android): Add GradleTestKit tests for sentry.gradle.kts asset tasks
69a44c1 
Cover the generated-asset tasks introduced for issue #6750 (PRs #6751/#6753)
with functional tests that apply the real sentry.gradle.kts script plugin to a
minimal AGP fixture and drive the tasks through GradleTestKit:

- SentryOptionsTaskTest: plain copy, SENTRY_RELEASE override, opt-out via
  SENTRY_COPY_OPTIONS_FILE=false, and missing-source fallback.
- SentryModulesTaskTest: modules.json generated into build/ (never src/main/
  assets), UP-TO-DATE on rebuild, skipCollectModules opt-out, and missing
  source map fallback.

Runs on the existing RNSentryAndroidTester testDebugUnitTest job, so no new CI
infrastructure is required.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • test(android): Add GradleTestKit tests for sentry.gradle.kts asset tasks by antonis in #6754
  • fix(android): Generate modules.json into build folder instead of source tree by antonis in #6753
  • fix(android): Generate sentry.options.json into build folder instead of source tree by antonis in #6751
  • fix(core): Declare optional peer dependencies to resolve phantom imports under strict package managers by antonis in #6729
  • Add missing exports and update public API report by antonis in #6731
  • test(ios): Reenable Session Replay E2E test by antonis in #6737
  • fix(ios): Honor shutdownTimeout on iOS by antonis in #6749

🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.27 ms 455.69 ms 24.42 ms
Size 50.56 MiB 56.50 MiB 5.93 MiB

Baseline results on branch: al/fix-gradle-modules-generated-assets

Startup times

Revision Plain With Sentry Diff
3bacb46+dirty 423.54 ms 428.93 ms 5.39 ms

App size

Revision Plain With Sentry Diff
3bacb46+dirty 50.56 MiB 56.50 MiB 5.93 MiB

@sentry

sentry Bot commented Sep 18, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.27.0 (107) Release

⚙️ sentry-react-native Build Distribution Settings

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.98 ms 441.69 ms 18.71 ms
Size 50.56 MiB 56.50 MiB 5.93 MiB

cursor[bot]
cursor Bot reviewed Sep 18, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 69a44c1. Configure here.

This was referenced Sep 18, 2026
Open
Open
@antonis
antonis marked this pull request as ready for review September 18, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@alwx alwx Awaiting requested review from alwx alwx is a code owner
@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antonis