feat(server): Add Resumable Upload API - #593
Draft
jan-auer wants to merge 14 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lcian
changed the title
Encode opaque session tokens as canonical unpadded base64url at the API boundary. Remove Location construction and its OriginalUri plumbing. Return HTTP 501 when the selected backend declines resumable uploads. Allow wildcard offset queries without Content-Length and verify their bodies are empty. Reject wildcard requests carrying payload bytes with HTTP 400. Update protocol documentation and endpoint tests for the revised wire behavior. Refs FS-470
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0c6f8f3. Configure here.
Route query-selected object operations through dedicated Axum handlers. Give each operation a focused extractor set. Model resumable selection as an optional target. Forward decoded session tokens through request extensions to avoid parsing them twice. Align endpoint and service terminology for object insertion and upload cancellation. Update backend hooks, response types, telemetry labels, documentation, and tests.
This comment has been minimized.
This comment has been minimized.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0df3274. Configure here.
Parse resumable query parameters synchronously from the request URI and return ApiError from route classification. This keeps response rendering in the dispatchers and avoids carrying a large Response in the Result error variant.
Reject Upload-Offset: * requests immediately when Content-Length declares a non-empty body. Continue inspecting the body stream so chunked or otherwise undeclared payloads are also rejected.
Render range and resumable offset errors through ApiError so their status, protocol headers, and response bodies are defined in one place. Let object and resumable endpoints propagate the structured service errors directly.
Reject bodies on session creation through shared empty-body validation, and treat unsupported functionality as a routine debug-level outcome. Clarify that session tokens are opaque, chunks require a declared length over HTTP/2, and fully uploaded sessions must commit or return an error.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 69a0db5. Configure here.
Implement ResumableTarget as an optional Axum parts extractor so dispatch handlers receive the classified target directly. Keep the loose query representation private and pass only existing session tokens through request extensions.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a53faae. Configure here.
Build unsatisfiable range responses in the object endpoint and attach authoritative offsets in the resumable continuation path. Keep generic ApiError conversion free of operation-specific response headers.
Reparse and validate session tokens in continuation and cancellation leaf handlers, removing the request-extension handoff. Keep route classification as a marker and return the regular delete status directly through IntoResponse.
Remove service-side token validation and let backends decide whether a token identifies an upload session. Split the catch-all request error into unknown-session and structured chunk-length outcomes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Resumable Upload interface on the backend trait and the API endpoints.
By default, all backends decline with
501 Not Implemented.Spec
Close FS-470