Rename binary ditto → dittosh - #2
Merged
Merged
Conversation
Binary, env vars (DITTOSH_DATA_DIR, DITTOSH_CONFIG_DIR, DITTOSH_QUIET, DITTOSH_NO_UPDATE_CHECK), OS data/config dirs, and docs all move to dittosh. Also fixes an over-escaped em-dash in the package.json description introduced by the rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The macOS/Linux
dittotool already owns that name in$PATH. Renaming the CLI binary todittoshavoids the clash.What changed
package.jsonbin entry and commander program name →dittoshDITTO_DATA_DIR→DITTOSH_DATA_DIR,DITTO_CONFIG_DIR→DITTOSH_CONFIG_DIR,DITTO_QUIET→DITTOSH_QUIET,DITTO_NO_UPDATE_CHECK→DITTOSH_NO_UPDATE_CHECKditto→dittosh(data + config dirs)getditto/tap/dittosh)Also fixes an over-escaped em-dash in the
package.jsondescription introduced during the rename.Verification
npm run typecheck✅npm run lint✅ (96 files)npm run test:unit✅ (447 tests, 34 files)