Stage 0: Loops Exercises by Adrianamm · Pull Request #295 · frcsoftware/frcsoftware.org

Adrianamm · 2026-09-16T02:42:38Z

Description

What changed?
Why? (the code + comments should speak for itself on the "how")
Exercises.

Any issues this pull request closes or pull requests this supersedes should be linked with Closes #289 .

Meta

Merge checklist:

Pull Request title is short, imperative summary of proposed changes
The description documents the what and why, including events that led to this PR
Pull Request has been linted and formatted and follows the styleguide

github-actions · 2026-09-16T02:43:40Z

🌐 Preview URL: https://pr-295-frcsoftware.frcsoftware.workers.dev

Spaceman113138

There is a bit of inconsistantcy as to if there is a period at the end of a sentance or not.

Co-authored-by: Spaceman 11 <135277197+Spaceman113138@users.noreply.github.com>

Spaceman113138

3rd times the charm

Co-authored-by: Spaceman 11 <135277197+Spaceman113138@users.noreply.github.com>

Co-authored-by: Sam Freund <samf.236@proton.me>

EdanThomton · 2026-09-17T23:54:26Z

+    for (int timer = 15; timer >= 0; timer--){
+        if (timer <= 0 ){
+            drivetrain.setThrottle(0);
+


is this extra line the result of spotless/prettify or is it accidental?

EdanThomton

There's some inconsistent formatting of variable names in the comments, but other than that it looks good to me!

EdanThomton · 2026-09-17T23:55:45Z

+
+    // First, create a for loop that has a new integer variable named 
+    // `timer` that is set to 15. The for loop checks if `timer` is 
+    // greater than or equal to 0 then it decreases timer by one


Suggested change

// greater than or equal to 0 then it decreases timer by one

// greater than or equal to 0, then it decreases `timer` by one

EdanThomton · 2026-09-17T23:56:22Z

+
+    // First, create a for loop that has a new integer variable named 
+    // `timer` that is set to 15. The for loop checks if `timer` is 
+    // greater than or equal to 0 then it decreases timer by one


Suggested change

// greater than or equal to 0 then it decreases timer by one

// greater than or equal to 0, then it decreases `timer` by one

EdanThomton · 2026-09-17T23:59:04Z

+
+    // Create a for loop that has a new integer variable named `timer`
+    // that is set to 15. Check for when timer is greater than or equal to 0,
+    // then decrease timer by one. 


Suggested change

// then decrease timer by one.

// then decrease `timer` by one.

EdanThomton · 2026-09-17T23:59:13Z

+    System.out.println("but yours did");
+
+    // Create a for loop that has a new integer variable named `timer`
+    // that is set to 15. Check for when timer is greater than or equal to 0,


Suggested change

// that is set to 15. Check for when timer is greater than or equal to 0,

// that is set to 15. Check for when `timer` is greater than or equal to 0,

EdanThomton · 2026-09-17T23:59:33Z

+void main() {
+
+    // First, create a new integer variable named `error`
+    // Below, create a while loop that compares if error is less than 5


Suggested change

// Below, create a while loop that compares if error is less than 5

// Below, create a while loop that checks if `error` is less than 5

EdanThomton · 2026-09-18T00:02:32Z

+    // First, create a new integer variable named `error`
+    // Below, create a while loop that compares if error is less than 5
+    // if that is true, print "Robots should not quit", then increase `error` by one
+    // if error is no longer less than 5, print "but yours did"


Suggested change

// if error is no longer less than 5, print "but yours did"

// when `error` is no longer less than 5, print "but yours did"

EdanThomton · 2026-09-18T00:02:57Z

+
+
+    // Create a for loop that has a new integer variable named `timer`
+    // that is set to 15. Check for when timer is greater than or equal to 0,


Suggested change

// that is set to 15. Check for when timer is greater than or equal to 0,

// that is set to 15. Check for when `timer` is greater than or equal to 0,

EdanThomton · 2026-09-18T00:03:05Z

+
+    // Create a for loop that has a new integer variable named `timer`
+    // that is set to 15. Check for when timer is greater than or equal to 0,
+    // then decrease timer by one. 


Suggested change

// then decrease timer by one.

// then decrease `timer` by one.

EdanThomton · 2026-09-18T00:03:50Z

+    // First, create a for loop that has a new integer variable named 
+    // `timer` that is set to 15. The for loop checks if `timer` is 
+    // greater than or equal to 0 then it decreases timer by one
+    // Inside the for loop, have an if statement that checks if timer


Suggested change

// Inside the for loop, have an if statement that checks if timer

// Inside the for loop, have an if statement that checks if `timer`

EdanThomton · 2026-09-18T00:04:00Z

+    // greater than or equal to 0 then it decreases timer by one
+    // Inside the for loop, have an if statement that checks if timer
+    // is less than or equal to 0. If so, set the drivetrain speed to 0
+    // If the timer is less than or equal to 15, set the speed to one


Suggested change

// If the timer is less than or equal to 15, set the speed to one

// If the `timer` is less than or equal to 15, set the speed to one

ArchdukeTim · 2026-09-18T00:57:33Z

+
+class Drivetrain {
+    /**
+     * Dummy function that spins drivetrain motors at the specified speed.


Suggested change

* Dummy function that spins drivetrain motors at the specified speed.

* Mock function to simulate running drivetrain motors at specified throttle

It's probably best to use throttle as the variable name

ArchdukeTim · 2026-09-18T01:12:22Z

+    // if that is true, print "Robots should not quit", then increase `error` by one
+    // if error is no longer less than 5, print "but yours did"


This example is funny to us, but might be confusing and not very intuitive what the students should be trying to accomplish with this loop. What if we made a more realistic scenario like:

A robot gyro must be calibrated before using it. Calibrating is done by printing "Calibrating..." to the console 5 times. Using a while loop and an integer, calibrate the gyro, then print "Calibration successful"

Adrianamm added 2 commits September 15, 2026 22:35

Create loops.java

6c2bf72

aa

ba0c185

github-actions Bot added examples stage0 labels Sep 16, 2026

Spaceman113138 suggested changes Sep 16, 2026

View reviewed changes

Comment thread examples/stage0/solutions/src/loops.java Outdated

Comment thread examples/stage0/solutions/src/loops.java Outdated

Comment thread examples/stage0/templates/src/loops.java Outdated

Comment thread examples/stage0/templates/src/loops.java Outdated

Apply batched suggestions from code review

9285a03

Co-authored-by: Spaceman 11 <135277197+Spaceman113138@users.noreply.github.com>

Spaceman113138 suggested changes Sep 16, 2026

View reviewed changes

Comment thread examples/stage0/templates/src/loops.java Outdated

Adrianamm and others added 2 commits September 16, 2026 00:32

Update examples/stage0/templates/src/loops.java

2689abc

Co-authored-by: Spaceman 11 <135277197+Spaceman113138@users.noreply.github.com>

Merge branch 'main' into loops-excerises

4412623

Spaceman113138 approved these changes Sep 16, 2026

View reviewed changes

Comment thread examples/stage0/solutions/src/loops.java Outdated

Comment thread examples/stage0/solutions/src/loops.java Outdated

Adrianamm and others added 2 commits September 16, 2026 00:37

Apply batched suggestions from code review

df3f459

Co-authored-by: Spaceman 11 <135277197+Spaceman113138@users.noreply.github.com>

Update loops.java

507e100

samfreund reviewed Sep 16, 2026

View reviewed changes

Comment thread examples/stage0/templates/src/loops.java Outdated

samfreund reviewed Sep 16, 2026

View reviewed changes

Comment thread examples/stage0/solutions/src/loops.java Outdated

Apply batched suggestions from code review

038c2e9

Co-authored-by: Sam Freund <samf.236@proton.me>

EdanThomton reviewed Sep 17, 2026

View reviewed changes

EdanThomton suggested changes Sep 18, 2026

View reviewed changes

EdanThomton added this to the First Publish milestone Sep 18, 2026

ArchdukeTim reviewed Sep 18, 2026

View reviewed changes

Merge branch 'main' into loops-excerises

3ca2c9a

	// greater than or equal to 0 then it decreases timer by one
	// greater than or equal to 0, then it decreases `timer` by one

	// then decrease timer by one.
	// then decrease `timer` by one.

	// that is set to 15. Check for when timer is greater than or equal to 0,
	// that is set to 15. Check for when `timer` is greater than or equal to 0,

	// Below, create a while loop that compares if error is less than 5
	// Below, create a while loop that checks if `error` is less than 5

	// if error is no longer less than 5, print "but yours did"
	// when `error` is no longer less than 5, print "but yours did"



		// Create a for loop that has a new integer variable named `timer`
		// that is set to 15. Check for when timer is greater than or equal to 0,

	// Inside the for loop, have an if statement that checks if timer
	// Inside the for loop, have an if statement that checks if `timer`

	// If the timer is less than or equal to 15, set the speed to one
	// If the `timer` is less than or equal to 15, set the speed to one

	* Dummy function that spins drivetrain motors at the specified speed.
	* Mock function to simulate running drivetrain motors at specified throttle

		// if that is true, print "Robots should not quit", then increase `error` by one
		// if error is no longer less than 5, print "but yours did"

Conversation

Adrianamm commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Meta

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

Spaceman113138 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spaceman113138 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EdanThomton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Adrianamm commented Sep 16, 2026 •

edited

Loading