Add integration tests - #205
Merged
Merged
Conversation
ameba23
approved these changes
Sep 4, 2026
ameba23
left a comment
ameba23
left a comment
Contributor
There was a problem hiding this comment.
⭐ Great to have this as i have been checking this manually
Maybe put a note somewhere explaining that this test can be run manually from https://github.com/flashbots/devops/blob/main/.github/workflows/flashbox_integration_tests.yaml as i would not have guessed that if i didn't know.
MoeMahhouk
approved these changes
Sep 4, 2026
pablin-10
force-pushed
the
pablo/integration_tests
branch
from
September 4, 2026 18:27
3836768 to
2c4d0c8
Compare
Member
|
lgtm! maybe these should be in the devops repo colocated with the yaml file that runs them? i have a half finished separate repo that does a whole bunch more integration testing for other repos like attest. eventually, i think all this stuff will go in there. but for now we can just keep it with devops and migrate to a separate organization-wide integration testing suite repo later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.