Conversation
To drastically improve right-to-left language support I have manually updated all inline (left, right) properties to use their logical equivalent
Found two more files with missing refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To drastically improve right-to-left language support I have manually updated all inline (left, right) properties to use their logical equivalent.
Changes proposed in this pull request:
All core LESS styles to use logical properties for inline (left, right) styles. Global browser support today sits above 97%: https://caniuse.com/css-logical-props
Reviewers should focus on:
I did test and click through as many pages, modals and page variants as possible to validate the changes render identically, but more sets of eyes would always help
Necessity
Confirmed
yarn testinjs/).composer test).